Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Validation rule with * gets incorrect values as dot array syntax #8129

Merged
merged 7 commits into from
Nov 3, 2023
Merged

fix: Validation rule with * gets incorrect values as dot array syntax #8129

merged 7 commits into from
Nov 3, 2023
+161 −34

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 31, 2023 •
edited
Loading

Description
Fixes #8128
Superseds #8126

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities labels Oct 31, 2023
@kenjis kenjis mentioned this pull request Oct 31, 2023
Closed
5 tasks
@kenjis kenjis force-pushed the fix-validation-dot-array-syntax branch from 2fa0227 to 09e194d Compare October 31, 2023 01:00
@kenjis
Copy link
Member Author

kenjis commented Oct 31, 2023

Added changelog and upgrading.

@kenjis kenjis force-pushed the fix-validation-dot-array-syntax branch from 453f912 to 70734bd Compare October 31, 2023 02:28
@kenjis kenjis force-pushed the fix-validation-dot-array-syntax branch from 70734bd to 4913acc Compare October 31, 2023 02:33
@kenjis kenjis merged commit 3266127 into codeigniter4:develop Nov 3, 2023
61 checks passed
@kenjis kenjis deleted the fix-validation-dot-array-syntax branch November 3, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ping-yee ping-yee ping-yee approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Validation rule with * gets incorrect values as dot array syntax
3 participants
@kenjis @michalsn @ping-yee